fix(remote): forward collaboration mode and handle disconnect#146
Closed
slkzgm wants to merge 4 commits intoDimillian:mainfrom
Closed
fix(remote): forward collaboration mode and handle disconnect#146slkzgm wants to merge 4 commits intoDimillian:mainfrom
slkzgm wants to merge 4 commits intoDimillian:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the optional remote backend RFC (#54).
Summary
This is a small follow-up on top of #121 to make remote mode behave the same as local mode for collaboration selection, and to avoid commands hanging indefinitely after a daemon restart / TCP disconnect.
Changes
collaborationModein remotesend_user_message.collaboration_mode_listin remote mode.connectedflagpendingrequests when the read loop ends or the write loop hits an IO errorNotes
backendMode=remote).Validation
npm run lintnpm run typechecknpm run build